Skip to content

Oleksandr starshynov w2 react #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Oleksandr starshynov w2 react #11

wants to merge 4 commits into from

Conversation

aleksandrstarshynov
Copy link

@aleksandrstarshynov aleksandrstarshynov commented Jun 25, 2025 •
edited by ChingHsun
Loading

  • The fake-data directory should not be a part of your project anymore
  • Your app will need to make 2 queries to the following endpoints:
    • https://fakestoreapi.com/products/categories -> To get all the categories
    • https://fakestoreapi.com/products or https://fakestoreapi.com/products/category/:selectedCategory -> To get the products. The API needs to do the filtering, not the frontend. Usually the amount of products will be too large to do the filtering on the frontend.
  • Your app needs to show that it is loading when waiting on the request to come back. You can test this by mimicing a slow connection in your browsers' developer tools
  • Your app needs to show an error message if the request failed
  • Your app needs to go to a detail page /product/:id whenever you click on the product card in the list. This should get the details from the endpoint: https://fakestoreapi.com/products/<id>. For now we won't add a navigation bar, the browsers 'back' button will do the trick. TIP: You will need to add the react-router-dom package and add the routing to your app regardless.
  • You need to deploy your app somewhere (using something like netlify) and put the link in your PR! Make it a different one than the previous week.

@aleksandrstarshynov
Copy link
Author

https://ecommerce-w2-starshynov.netlify.app/
link to the week2 production instance

@ChingHsun
Copy link

Great job! The code is clear and well-structured. I especially like how the utils are separated out.
Everything meets the requirements. Approved ✅

@ChingHsun ChingHsun self-assigned this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChingHsun ChingHsun

Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandrstarshynov @ChingHsun